[Ocfs2-tools-devel] [PATCH]: Add removing slots support for ocfs2-tools

[tao.ma]

Sunil Mushran wrote:
> Tao,
>
> 3. remove_slot_1.patch
>
> a. In remove_slot_check:
> +       /* we don't allow remove_slot to coexist with other tunefs
> +        * options to keep things simple.
> +        */
> Can we move this check to get_options(). Similar checks are already 
> there.
I originally thought of that, but in the function get_options I can't 
get max_slots of the volume, so I can't put the check there.
>
> I have lot more comments for remove_slots(). But I am still going thru 
> the code.
>
> 4. tunefs_1.patch
>
> a. get_options has code to not allow < 2 slots. Make that 1.
We now allow max_slots to be 1? Oh, for local mount? Sure, I will modify it.
>
> b. Giving same number of nodes as configured should not be an error.
> Instead ignore the requested change.
OK.
>
> c. In main:
> +       /* Set remove slots incompat flag on superblock */
> I am sure we can reduce the code size by "merging" the code below with
> the resize_inprog.
OK.
> d. Fail if someone runs tunefs after a failed remove_slot without 
> running fsck.ocfs2.
yeah, I forgot about that. thanks.
>
>
> 5. group_check.patch
> 6. orphan_check.patch
> 7. journal_check.patch
> This three will be reviewed after I finish with remove_slots().
>
> ++ Begin nag
> Add comments atop each patch. ;)
> ++ End nag
heh, OK.
I will wait for all your comments and try to use quilt mail, divide 
those patches into many mails, add comments and send again. ;)