[Ocfs2-tools-devel] Re: [patch] Add test programs in ocfs2-test to verify removing slots. take 2

[Sunil Mushran]

preferred_slot mount option has been checked into the
1.2 branch. Will not work with 1.2.5. No changes in mount.ocfs2
required.

Marcos E. Matsunaga wrote:
> Tao,
>
> I think I missed something here. Did you send a patch to mount.ocfs2 
> to support preferred_slot option? Your script is calling mount with it 
> and it is failing. It is not in your original set of ocfs2-tools patches.
>
> Let me know if I missed a patch.
>
> tao.ma wrote:
>> Add test script in ocfs2-test to test whether removing slot can work OK.
>>
>> 1. remove_slot.c
>> This file is used to create some boudary situation to test whether
>> tunefs.ocfs2 can work OK with removing slots.
>> When we have orphan files or have some blocks allocated in truncate log
>> or local alloc, we can't remove the slots, so the option 
>> CREATE_ORPHAN_FILE,
>> CREATE_TRUNCATE_LOG and CREATE_LOCAL_ALLOC are used to check it.
>>
>> 2. remove_slot.sh
>> The normal test script to test whether tunefs.ocfs2 can work OK.
>>
>> 3. corrupt_remove_slot.patch
>> With this patch, tunefs.ocfs2 will abort at the specified place and 
>> we can check
>> whether fsck.ocfs2 can fix the aborted problem.
>>
>> 4. corrupt_remove_slot.patch
>> The main test script to test whether fsck.ocfs2 can recover from the 
>> aborted tunefs.ocfs2.
>>
>>
>> tao.ma at oracle.com wrote:
>>> tunefs.ocfs2 has been able to increase the slot for a long time.
>>> Now the support for removing slots is also added. There are also 
>>> some changes
>>> in debugfs.ocfs2 and fsck.ocfs2 to be fit for this new feature.
>>>
>>> Modification from v3 to v4:
>>>
>>> 1. Only check s_tunesfs_flag if FEATURE_INCOMPAT_TUNEFS is set in 
>>> ocfs2_open.
>>> http://oss.oracle.com/pipermail/ocfs2-tools-devel/2007-June/000222.html
>>>
>>> 2. Modify the following places in the process of removing slots.
>>>    1) Remove relink_alloc_action enums and use existing
>>>       INODE_ALLOC_SYSTEM_INODE instead.
>>>    2) Limit the use of globals in the static functions.
>>>    3) Rename new_inode to dst_blkno as it is the blkno for dst_inode.
>>> http://oss.oracle.com/pipermail/ocfs2-tools-devel/2007-June/000224.html
>>>
>>> 3. Fix a bug when we remove the system file entry from the system 
>>> directory.
>>>   
>
> -- 
>
> Regards,
>
> Marcos Eduardo Matsunaga
>
> Oracle USA
> Linux Engineering
>
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel