[Ocfs2-tools-devel] [PATCH] fsck.ocfs2: Simple memory leak in check_journal_super()

Joel Becker joel.becker at oracle.com
Fri Dec 7 15:58:18 PST 2007


The check_journal_super() allocates a buffer to read the journal
superblock and never frees it.  Fix.

Signed-off-by: Joel Becker <joel.becker at oracle.com>
---
 fsck.ocfs2/journal.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fsck.ocfs2/journal.c b/fsck.ocfs2/journal.c
index b865926..417a101 100644
--- a/fsck.ocfs2/journal.c
+++ b/fsck.ocfs2/journal.c
@@ -742,6 +742,7 @@ static errcode_t check_journal_super(ocfs2_filesys *fs,
 		goto out;
 
 	ret = ocfs2_read_journal_superblock(fs, blkno, buf);
+	ocfs2_free(&buf);
 out:
 	return ret;
 }
-- 
1.5.2.2




More information about the Ocfs2-tools-devel mailing list