[Ocfs2-tools-devel] Patch for journal truncate of ocfs2-tools.

[Sunil Mushran]

On Fri, 2007-04-27 at 09:27 +0800, tao.ma wrote:
> Sunil Mushran wrote:
> In the furture implementation of ocfs2_truncate for sparse_files, 
> ocfs2_truncate will only increase the size when the user do the 
> extending and I preserve the function of ocfs2_extend_allocation which 
> will allocate the clusters when extending. So I don't want to modify 
> this function then to fit this need.

OK.

> From the code it seems that we used to make the journal size smaller 
> only under the condition that we change the numbers of slots, so here we 
> have the check of "if (!opts.num_slots)". But now we can decrease the 
> journal size without touching the number of slots, so we shouldn't care 
> whether we change num_slots or not. Am I wrong? Please point it out.

The code used to handle the situation in which the user extends the
journal size and adds slots at the same time. The current code cannot
handle that.

Again, I am ok with making the two ops exclusive. As in, disallow
changing slots and changing journal files at the same time. It may make
life easier both coding/testing wise and not take much from the user.