[Ocfs2-tools-devel] debugfs.ocfs2 usage message fix
Sunil Mushran
Sunil.Mushran at oracle.com
Mon Sep 11 18:17:39 PDT 2006
Not sure we need this. We typically use the term block# and inode#
interchangeably as (unlike ext3) not only can a block only have one
inode but also that the inode# is the same as the block#. Having said that,
I would prefer to use just one of them in help (in this case block#) so as
to keep it simple and not confuse users into believing there was a
difference
between the two.
GONG Jie wrote:
> Hi, all
>
> I have re-create the patch.
>
> Since command ``ncheck'', ``findpath'', ``locate'', ``extent'', ``group'' all
> call function process_inodestr_args to process their arguments. But
> ``ncheck'', ``findpath'' and ``locate'' expect inode number, ``extent'',
> ``group'' expect block number.
>
> So I fix the do_help() and change process_inodestr_args() to process these two
> situation.
>
> On Thursday 24 August 2006 17:43, GONG Jie wrote:
>
>> The help message in debufs.ocfs2 is not consist among ``extent'',
>> ``findpath'', ``locate'', ``ncheck'' and ``help''.
>>
>> ``help'' show that extent accept a block number as its argument.
>> ---8<---
>> extent <block#> Show extent block
>> ---8<---
>>
>> But ``extent'' says its argument is an inode number.
>> ---8<---
>> debugfs: extent
>> usage: extent <inode#>
>> ---8<---
>>
>> It is confused. So I change function process_inodestr_args() to fix that.
>>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel
>
More information about the Ocfs2-tools-devel
mailing list