[Ocfs2-tools-devel] Re: ocfs2-tools for Debian/Ubuntu

[Fabio Massimo Di Nitto]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Joel Becker wrote:


> 	We haven't started pushing them upstream, so there is no status
> yet :-)

ok.


> 	Well, my other packages are not Oracle related, just personal
> stuff, so very low priority :-)
> 

ehhe ok :)

> 
>>Sure.. so should we move the comment/suggestion to the mailing list
>>or do you prefer to keep it between us?
>>Unfortunatly I figured out a release too late that there were separate
>>mailing lists for the -tools (reason why i didn't show up before debian/ hitted
> 
> 
> 	Mailing list would be better.  We're not trying to hide anything
> here :-)

perfect.. moving to ocfs2-tools-devel, let me know if you prefer another forum.

I did today a review of debian/ in 0.99.12 and here is what i think could be
improved (most of them are cosmetic changes):

- - the 2 {ocfs2console,ocfs2-tools}.copyright files are identincal. You can just
  rename one of them copyright and remove the other. The file will be installed
  automatically in both the binary packages. It will save you the time to update
  it in one place when/if required.

- - you can safely remove all the *.{pre,post}inst files. When only the #DEBHELPER#
  keyword is required, the different dh_* tools will create them for you appropriately
  and include in the package. No need to carry around N empty files.

- - The README.Debian is empty :). There is no real need to ship one. It's up to maintainer
  if you want to ship extra specific distro documentation or information to the user, but
  it's not mandatory.

- - debian/rules is pretty ok. I usually (but this is really a personal preference) remove
  all the calls that are not needed to build the package. Including the ones that are commented
  out from the different examples.
  I also tend to avoid recursive calls to debian/rules, but again.. that's really a matter
  of what you prefer ;)

- - we share basically the same debian/control (compared to ubuntu). You can safely bump
  Standards-Version: from 3.5.6 to 3.6.1. The package seems clean enough for that,

Now there are a few interesting points to look at ;)

You builded very nice packages for sarge, but I think we should also look at what would
be the future of it. In Ubuntu i used python2.4 and given that it is also in Debian,
it is worth to leave 2.3 behind.

Another little thing that i noticed is that you make use of /etc/default/$pkgsname. Since
ocfs2 requires also the cluster config file, I did put them together in /etc/ocfs2/
so that config files are not placed in different directories (Specially when there
is more than one, it can become confusing for people approaching the pkgs for the first time).
This is still a question of personal choise. I don't recall any specific Debian Policy
to regulate it.

The last thing (that i still need to fix in Ubuntu too) is the way in which the configfile
(/etc/default/o2cb) is manipulated. Using "/etc/init.d/o2cb configure" is not exactly the
Debian way of doing packages configuration.
Usually that kind of logic is implemented in the package postinst script and using a tool/frontend
called debconf (that will be mandatory to use for etch).
I am working right now on it and i will be glad to push you the patch back for it as soon as i get
around to finish it ;)

Cheers
Fabio

- --
no signature file found.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQIVAwUBQsBu7FA6oBJjVJ+OAQJQbxAAgTdDYnyw5Vpt9YRu7XiGDw9apONkbLG6
i2kAaUr+PdonKwVok6E7pOf1Qfp5pgtD/QkTGF4dcvQTCm4nvfnP2CqTG17hxVPg
OEge9UdDtRVVYB7TaSPmDCLFIfeXXgHjIiNnldFwUyCMv+iDKC64JydMZXMrlReg
LFefnR+qKdPURJhsgRt3FXImcqfTUIA2LPtW7o7Um+4DEO7ZrdHwng4A8XyH5cMp
Oort1oJ1zTOvdriNANR1jsH1xdP09ddJZb5hBGEGT8/3aIGYfvAMGdIJi4Z0XR3t
IW66UAlEck8OiQPZ5UyJNP8P8lFG4grs0SENxyZ2XeO4wx1rgKgyxQN9NfxY0yr0
qsVfCQ254eXVfjgw0H7nGIgsMdD8etEvaaqIF7JGfalqoX4WBAW98SnqgPAymn2N
ZNq0UVqt2lRQNQjDLrQNo/aB5On5QiApgfbgwZBvrpzxO9s+jHvQH/+OKEm/XZ5w
gae3UGoqVzh93JPLkdbC3asDONHcHflLy79f8F7JKX0rVeu3PJpIGUBK4V8/gQec
f32Fr6rObbBeVnoIXaPAAsZOhM1kP/78YBMBdjppQ/DjQkZEDdbLNxiOcnf3Ikwh
iEWh4jVA1DjKDTLm5vzLEY8RehPiSJK8tSh63UXr3DB0biH86btkKnA4IfO5y8Ww
MsgxYHg28Kg=
=OuET
-----END PGP SIGNATURE-----