[Ocfs2-tools-devel] Re: [Ocfs2-tools-commits] smushran commits r430 - in trunk: libocfs2 tunefs.ocfs2

Sunil Mushran Sunil.Mushran at oracle.com
Mon Nov 22 12:03:34 CST 2004


Because for ocfs2_new_system_inode() the nodenum is -1.

Joel Becker wrote:

>On Fri, Nov 19, 2004 at 06:53:30PM -0600, svn-commits at oss.oracle.com wrote:
>  
>
>>suballocnode set correctly during init_inode
>>
>>-static void ocfs2_init_inode(ocfs2_filesys *fs, ocfs2_dinode *di,
>>+static void ocfs2_init_inode(ocfs2_filesys *fs, ocfs2_dinode *di, int16_t node,
>> 			     uint64_t gd_blkno, uint64_t blkno)
>>    
>>
>
>	Ugh!  The library explicity uses node 0.  Why make the API have
>an ugly, unused variable?
>
>Joel
>
>  
>



More information about the Ocfs2-tools-devel mailing list