[Ocfs2-tools-commits] branch, master, updated. ocfs2-tools-1.4.0-548-ge5474e5

[svn-commits at oss.oracle.com]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Tools to manage the ocfs2 filesystem.".

The branch, master has been updated
       via  e5474e5d6cd22ac9262562ec87947cc9a236d736 (commit)
       via  69af0891be449cff4e299c50eab333057d5ae679 (commit)
      from  fa0f4ba66581724930d478cf4463ba46928945e3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e5474e5d6cd22ac9262562ec87947cc9a236d736
Author: Tristan Ye <tristan.ye at oracle.com>
Date:   Tue Jun 1 14:12:10 2010 +0800

    O2image: Handle xattr btree for o2image.
    
    We do need to collect all bucket leaves of xattr btree if it exists
    in any inodes.
    
    Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
    Signed-off-by: Srinivas Eeda <srinivas.eeda at oracle.com>

commit 69af0891be449cff4e299c50eab333057d5ae679
Author: Tristan Ye <tristan.ye at oracle.com>
Date:   Mon May 24 20:25:39 2010 +0800

    O2image: A potential bug in o2image.
    
    Currently, we're using a scaling-down strategy to alloc memory chunk
    for o2image's bitmap blocks, the unerdyling alloc function which we
    were using(ocfs2_malloc_blocks) treat channel_io_blksz as basic unit.
    which may be smaller than our OCFS2_IMAGE_BITMAP_BLOCKSIZE(512 vs 4096).
    
    As a result, the problem is we're probably going to miss some blocks to allocate
    if the actual allocsize is not a multiple of OCFS2_IMAGE_BITMAP_BLOCKSIZE.
    
    Say we have 4096 * 17(bitmap blocks) to allocate, and failed at the first attemp,
    while did succeed after trying 'allocsize >>1', actually '2048 * 17' only fills up
    8 image bitmap blocks, therefore, we get 16 image bitmap blocks allocated eventually.
    Now one block was missed.
    
    I guess it's very likely to hit if the number of bitmap blocks is odd, am I understanding
    incorrectly?
    
    Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
    Signed-off-by: Srinivas Eeda <srinivas.eeda at oracle.com>

-----------------------------------------------------------------------

Summary of changes:
 libocfs2/image.c  |    6 ++++++
 o2image/o2image.c |   38 +++++++++++++++++++++++++++++++++++++-
 2 files changed, 43 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Tools to manage the ocfs2 filesystem.