[Ocfs2-tools-commits] branch, dx_dirs, updated. ocfs2-tools-1.4.0-532-ga1f51fa
svn-commits at oss.oracle.com
svn-commits at oss.oracle.com
Tue Apr 27 13:31:24 PDT 2010
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Tools to manage the ocfs2 filesystem.".
The branch, dx_dirs has been updated
via a1f51faeba55a493e23140cfd0822c7b9104a38d (commit)
via ab45dfd8026209389bf6dafc35177cc70630c082 (commit)
via eacab2f8b7ffa20d0852f8e26ff0a74f1a6efe34 (commit)
via 31b2748ec02454cbc35e148261c10e9009229676 (commit)
via cde47ca3ec0743d96b7e04ab887e68d44c060b18 (commit)
via 1801b29094c6adcf137739fd324fa4808fb410b5 (commit)
via f410d8aa377faad8d2d5a04ad6387128da0e2bcc (commit)
via c3b19e5097904b6fabdf290bfcfb77a3a35c12e1 (commit)
via c80525fb911d0eaf72bdd60374dd0d91c770bc29 (commit)
from 4c1cf61779ee71c828134d956f5779e272a3195e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a1f51faeba55a493e23140cfd0822c7b9104a38d
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:50:59 2010 +0800
dx_dirs: fix ocfs2_swap_dx_entry_list() for big endian
As Tao Ma suggested, current ocfs2_swap_dx_entry_list() is
buggy for big endian hardware, because after dl_list->de_count
swapped, it is referenced in the following loop.
This patch fixes this bug with adding an 'int to_cpu' argument, also
modifies other routines who call ocfs2_swap_dx_entry_list().
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit ab45dfd8026209389bf6dafc35177cc70630c082
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:50:18 2010 +0800
dx_dirs: set OCFS2_INDEXED_DIR_FL after indexed tree gets built
In ocfs2_dx_dir_build(), current code set OCFS2_INDEXED_DIR_FL to
di->i_dyn_features before inserting dir entries into the indexed tree.
If there is any error during the insertion, the corresponded dirent will
be lost from the indexed tree. Though this error can be checked and
fixed in fsck.ocfs2, it should be fixed.
This patch modifies to set OCFS2_INDEXED_DIR_FL after
ocfs2_dir_iterate() returns successfully. If ocfs2_dir_iterate() returns
with error, ocfs2_dx_dir_build() will return error and stop to build the
indexed tree for a specific directory. In this case, no dirent will be
losted.
Thanks to Tao Ma to catch this.
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit eacab2f8b7ffa20d0852f8e26ff0a74f1a6efe34
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:49:54 2010 +0800
dx_dirs: stop dx insert iteration for callback error
Callback ocfs2_dx_dir_insert() may encounter memory alloc or I/O error.
These kind of errors can not return to caller of the callback directly,
so the dir block iteration for dx insert can not stop immediately when
such errors occure.
This patch adds a member 'errcode_t err' to struct dx_insert_ctxt, which
can catch the error and permit ocfs2_dx_dir_insert() returns
OCFS2_EXTENT_ERROR to it's caller to stop the iteration immediately.
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit 31b2748ec02454cbc35e148261c10e9009229676
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:48:08 2010 +0800
dx_dirs: stop iteration of dir trailer initialization for I/O error
Callback dir_trailer_func() may encounter malloc or I/O error, these
errors can not return to its caller directly. This patch add a member
'errcode_t err' to struct trailer_ctxt, which can catch the error. By
this fix, dir_trailer_func() can return OCFS2_EXTENT_ERROR to stop dir
iteration immediately and can return the REAL error as well.
Thanks to Tao Ma catches this error.
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit cde47ca3ec0743d96b7e04ab887e68d44c060b18
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:47:35 2010 +0800
dx_dirs: Improve information displayed by dump_dx_root()
If dr->dr_suballoc_slot is OCFS2_INVALID_SLOT (which should not happen),
should not display "Global", because there is not "Global" conception
for dx root allocation slot. This patch fixes the display by
"Invalid Slot".
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit 1801b29094c6adcf137739fd324fa4808fb410b5
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:47:14 2010 +0800
dx_dirs: unifiy feature string of indexed-dirs
This patch changes the indexed-dirs fn_name of ocfs2_feature_name array
from IndexedDirs to indexed-dirs. Which unitifies fn_name displayed in
debugfs.ocfs2 to feature string 'indexed-dirs' used in mkfs.ocfs2 and
tunefs.ocfs2.
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit f410d8aa377faad8d2d5a04ad6387128da0e2bcc
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:46:49 2010 +0800
dx_dirs: remove unncessary return value assignment
This patch removes unnecessary return value assigned in
ocfs2_dx_entries_iterate() and ocfs2_dx_frees_iterate().
Thanks for Tao Ma for catching this.
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit c3b19e5097904b6fabdf290bfcfb77a3a35c12e1
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:46:33 2010 +0800
dx_dirs: check callback iter->dx_func() return value in dx_iterator()
This patch makes dx_iterator() check returned value of callback
iter->dx_func(). If an error returned from the callback, dx_iterator()
returns OCFS2_EXTENT_ERROR to stop the iteration.
Thanks to Tao Ma for catching the error.
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
commit c80525fb911d0eaf72bdd60374dd0d91c770bc29
Author: Coly Li <coly.li at suse.de>
Date: Tue Apr 27 15:45:52 2010 +0800
dx_dirs: stop iterate dir entries for I/O error
Callback dx_iterator() may encounter an I/O error when calling
ocfs2_read_dx_leaf(). The caller of dx_iterator is extent_iterate_el(),
which does not accept error code other than OCFS2_EXTENT_ERROR and
OCFS2_EXTENT_ABORT. The result is, dir entries iteration can not stop
if there is an I/O error happens in dx_iterator().
This patch add 'errcode_t err' member to struct dx_iterator_data, if
error returned from ocfs2_read_dx_leaf(), the error code will be
stored here, then dx_iterator() returns OCFS2_EXTENT_ERROR to make
extent_iterate_el() quit.
Thanks to Tao Ma for catching this error.
Signed-off-by: Coly Li <coly.li at suse.de>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tao Ma <tao.ma at oracle.com>
-----------------------------------------------------------------------
Summary of changes:
debugfs.ocfs2/dump.c | 2 +-
libocfs2/dir_indexed.c | 107 +++++++++++++++++++++++++++++++--------------
libocfs2/dir_iterate.c | 33 +++++++++-----
libocfs2/dirblock.c | 41 ++++++++---------
libocfs2/extents.c | 14 +++---
libocfs2/feature_string.c | 2 +-
6 files changed, 125 insertions(+), 74 deletions(-)
hooks/post-receive
--
Tools to manage the ocfs2 filesystem.
More information about the Ocfs2-tools-commits
mailing list