[Ocfs2-tools-commits] branch, master, updated. ocfs2-tools-1.4.0-279-g7e187d6
svn-commits at oss.oracle.com
svn-commits at oss.oracle.com
Thu Apr 9 17:14:11 PDT 2009
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Tools to manage the ocfs2 filesystem.".
The branch, master has been updated
via 7e187d6afdb6320c10c25b13bb28f10fcc74ca97 (commit)
from 74df2004a41370ef3e55c1d5aa5739e8529c5ab3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7e187d6afdb6320c10c25b13bb28f10fcc74ca97
Author: Coly Li <coly.li at suse.de>
Date: Fri Mar 13 01:25:36 2009 +0800
mounted.ocfs2: check length of names in ocfs2_print_nodes()
This patch is original from "[RFC] PATCH: verify slot number in
_ocfs2_read_slot_map(), v2". Thanks to Sunil and Joel for their comments and review.
In some buggy conditions, mounted.ocfs2 does dirty reads, when it happens, in
ocfs2_print_nodes():
66 node_num = map->md_slots[i].sd_node_num;
67 if (names && names[node_num] && *(names[node_num]))
node_num in 66 may be a very large number (due to the invalid data from
__ocfs2_read_slot_map()), and names[node_num] references to an illegal memory
region.
This patch adds third parameter 'length_of_names'to ocfs2_print_nodes(), when
node_num >= length_of_names, mounted.ocfs2 will display error message in this style:
# mounted.ocfs2 -f
Device FS Nodes
/dev/hdb1 ocfs2 Unknown
As Joel mentioned, this patch only fixes current o2cb stack issue. More work is
needed to make a completely solution for both o2cb and user space cluster stacks.
Signed-off-by: Coly Li <coly.li at suse.de>
Signed-off-by: Joel Becker <joel.becker at oracle.com>
-----------------------------------------------------------------------
Summary of changes:
mounted.ocfs2/mounted.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
hooks/post-receive
--
Tools to manage the ocfs2 filesystem.
More information about the Ocfs2-tools-commits
mailing list