[Ocfs2-tools-commits] zab commits r268 - trunk/fsck.ocfs2

[svn-commits at oss.oracle.com]

Author: zab
Date: 2004-09-27 19:07:19 -0500 (Mon, 27 Sep 2004)
New Revision: 268

Modified:
   trunk/fsck.ocfs2/pass1.c
Log:
o bring back the signature check, sort of.


Modified: trunk/fsck.ocfs2/pass1.c
===================================================================
--- trunk/fsck.ocfs2/pass1.c	2004-09-27 23:42:30 UTC (rev 267)
+++ trunk/fsck.ocfs2/pass1.c	2004-09-28 00:07:19 UTC (rev 268)
@@ -64,14 +64,13 @@
 
 	/* clamp inodes to > OCFS2_SUPER_BLOCK_BLKNO && < fs->fs_blocks? */
 
-	/* what's our deletion story?  i_links_count, dtime, etc.. */
-
-#if 0 /* XXX we don't care about the signature on inodes? */
+	/* XXX need to compare the lifetime of inodes (uninitialized?
+	 * in use?  orphaned?  deleted?  garbage?) to understand what
+	 * fsck can do to fix it up */
 	if (memcmp(di->i_signature, OCFS2_INODE_SIGNATURE,
 		   strlen(OCFS2_INODE_SIGNATURE))) {
 		goto bad;
 	}
-#endif
 
 	if (di->i_links_count)
 		o2fsck_icount_update(ost->ost_icount_in_inodes, di->i_blkno,
@@ -122,6 +121,7 @@
 
 	return;
 bad:
+	/* XXX we don't actually do anything with this bitmap */
 	ocfs2_bitmap_set(ost->ost_bad_inodes, blkno, NULL);
 }
 
@@ -311,6 +311,7 @@
 		}
 		if (blkno == 0)
 			break;
+
 		/* scanners have to skip over uninitialized inodes */
 		if (!(di->i_flags & OCFS2_VALID_FL))
 			continue;