[Ocfs2-test-devel] [PATCH 45/59] flock-test: disable posix lock test

[Junxiao Bi]

On 09/23/2015 01:41 PM, Eric Ren wrote:
> Hello Junxiao,
> 
> Please look at comment below.
> 
> On Wed, Sep 23, 2015 at 08:31:30AM +0800, Junxiao Bi wrote: 
>> On 09/22/2015 09:58 PM, Eric Ren wrote:
>>> Hello Junxiao,
>>>
>>> By "doesn't support", you mean o2cb stack doesn't support fcntl
>>> file lock? Did you ever try pacemaker for this?
>> No, i didn't try pacemarker. Posix range lock is not supported by o2cb.
>> But i don't think it will cause a hung. Maybe the dlm used by pacemarker
>> have some bug to support posix lock.
> 
> Thus, we must consider pacemaker. Could you please make a conditional
> judge with cluster stack?
May export an variable from the vendor and with that variable to decide
posix lock support.

Thanks,
Junxiao.
> 
> Thanks,
> Eric Ren
> 
>>
>> Thanks,
>> Junxiao.
>>>
>>> Actually, I encountered an testing failure just on this point with
>>> pacemaker 2-nodes cluster.
>>>
>>> Threads on both node hung for ever. Is this same as your case?
>>> Please help take a look at:
>>>
>>> m1:/opt/ocfs2-test/bin # cat /proc/21139/stack
>>> [<ffffffff8104150b>] kvm_clock_get_cycles+0x1b/0x20
>>> [<ffffffff810b98f4>] __getnstimeofday+0x34/0xc0
>>> [<ffffffff8104150b>] kvm_clock_get_cycles+0x1b/0x20
>>> [<ffffffff810b9bb2>] ktime_get_ts+0x42/0xe0
>>> [<ffffffff8105bbbe>] SyS_gettimeofday+0x2e/0x70
>>> [<ffffffff81528d89>] system_call_fastpath+0x16/0x1b
>>> [<ffffffffffffffff>] 0xffffffffffffffff
>>>
>>> m2:/opt/ocfs2-test/log # cat /proc/19906/stack
>>> [<ffffffffa0556a65>] dlm_posix_lock+0x185/0x380 [dlm]
>>> [<ffffffff811f2bae>] fcntl_setlk+0x12e/0x2d0
>>> [<ffffffff811b7271>] SyS_fcntl+0x261/0x510
>>> [<ffffffff81528d89>] system_call_fastpath+0x16/0x1b
>>> [<00007ff690db3b42>] 0x7ff690db3b42
>>> [<ffffffffffffffff>] 0xffffffffffffffff
>>>
>>> Thanks,
>>> Eric Ren
>>>
>>> On Mon, Sep 14, 2015 at 10:44:31AM +0800, Junxiao Bi wrote: 
>>>> Disable posix lock test for o2cb stack as it doesn't support.
>>>>
>>>> Signed-off-by: Junxiao Bi <junxiao.bi at oracle.com>
>>>> ---
>>>>  programs/python_common/multiple_run.sh |   10 +++++++---
>>>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/programs/python_common/multiple_run.sh b/programs/python_common/multiple_run.sh
>>>> index 8483769..101dcb0 100755
>>>> --- a/programs/python_common/multiple_run.sh
>>>> +++ b/programs/python_common/multiple_run.sh
>>>> @@ -450,12 +450,16 @@ run_flock_unit_test()
>>>>  	local workplace=${MOUNT_POINT}/flock_unit_test
>>>>  	local testfile1=${workplace}/flock_unit_test_file1
>>>>  	local testfile2=${workplace}/flock_unit_test_file2
>>>> +	local posix_lock_supported=0
>>>>  
>>>>  	run_common_testcase "flock_unit" "sparse,unwritten,inline-data" \
>>>>  "${TOUCH_BIN} ${testfile1} && ${TOUCH_BIN} ${testfile2} && ${BINDIR}/run_flock_unit_test.py \
>>>> --l ${fcntl_logfile} -n ${NODE_LIST} -t fcntl -e ${testfile1} -f ${testfile2} \
>>>> -&& ${BINDIR}/run_flock_unit_test.py -l ${flock_logfile} -i ${INTERFACE} -n ${NODE_LIST} -t \
>>>> -flock -e ${testfile1} -f ${testfile2}"
>>>> +-l ${flock_logfile} -i ${INTERFACE} -n ${NODE_LIST} -t flock -e ${testfile1} -f ${testfile2}"
>>>> +
>>>> +	if [ $posix_lock_supported -eq 1 ]; then
>>>> +		${BINDIR}/run_flock_unit_test.py -l ${fcntl_logfile} -n ${NODE_LIST} -t fcntl \
>>>> +		-e ${testfile1} -f ${testfile2}
>>>> +	fi
>>>>  }
>>>>  
>>>>  f_cleanup()
>>>> -- 
>>>> 1.7.9.5
>>>>
>>>>
>>>> _______________________________________________
>>>> Ocfs2-test-devel mailing list
>>>> Ocfs2-test-devel at oss.oracle.com
>>>> https://oss.oracle.com/mailman/listinfo/ocfs2-test-devel
>>>>
>>
>>