[Ocfs2-test-devel] [PATCH 1/1] Ocfs2-test: Fix a silly bug of reflink_test.

Sunil Mushran sunil.mushran at oracle.com
Fri Feb 26 09:59:31 PST 2010


That was quick. ;)

ack

Tristan Ye wrote:
> The running script 'reflink_test_run.sh' is now using a wrong
> option('-D') to do DIRECTIO test for reflink, actually it will
> make the runner invoke another test, rather than the directio_test
>
> That's totally a silly mistake from me which caused we skip all the
> DIRECTIO testcases for single_node reflink_test, and make the reflink_test
> wasn't able to capture odirect bugs like bz1226 for reflink.
>
> Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
> ---
>  programs/reflink_tests/reflink_test_run.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/programs/reflink_tests/reflink_test_run.sh b/programs/reflink_tests/reflink_test_run.sh
> index 69ce4d3..b2dec57 100755
> --- a/programs/reflink_tests/reflink_test_run.sh
> +++ b/programs/reflink_tests/reflink_test_run.sh
> @@ -523,9 +523,9 @@ ${WORK_PLACE} -c 100 >>${LOG_FILE} 2>&1
>  	((TEST_NO++))
>          f_LogRunMsg ${RUN_LOG_FILE} "[${TEST_NO}] O_DIRECT Refcount Test:"
>          f_LogMsg ${LOG_FILE} "[${TEST_NO}] O_DIRECT Refcount Test, CMD:${SUDO} \
> -${REFLINK_TEST_BIN} -i 1 -n 100 -l 104857600 -d ${DEVICE} -w ${WORK_PLACE} -D "
> +${REFLINK_TEST_BIN} -i 1 -n 100 -l 104857600 -d ${DEVICE} -w ${WORK_PLACE} -O "
>          ${SUDO} ${REFLINK_TEST_BIN} -i 1 -n 100 -l 104857600 -d ${DEVICE} -w \
> -${WORK_PLACE} -D >>${LOG_FILE} 2>&1
> +${WORK_PLACE} -O >>${LOG_FILE} 2>&1
>          RET=$?
>          f_echo_status ${RET} | tee -a ${RUN_LOG_FILE}
>          f_exit_or_not ${RET}
>   




More information about the Ocfs2-test-devel mailing list