[Ocfs2-test-devel] [PATCH] dirop_file_racer: Add a prefix to the file names created.
Joel Becker
Joel.Becker at oracle.com
Wed Apr 29 21:15:54 PDT 2009
On Thu, Apr 30, 2009 at 11:19:18AM +0800, tristan.ye wrote:
> Why don't we add a variable in config.sh(config_shell.skel) then export
> it instead of adding an isolated environment var somewhere, other than
> this, all looks good to me:-)
It's specific to this test, not global, and it's something you
may only want to do at certain times. It's not something that belongs
in a global configure, I think.
> One more thing i think we can use DIR_FILE_PREFIX instead of PREFIX to
> make it more explicit to let others know it is going to be used just for
> dirop_file_racer testcase.
I went for an easier to type name, but I think you're right that
PREFIX is too simple. I'm going to change it to DIROP_FILE_PREFIX,
because it's specific to this test.
Joel
--
"When I am working on a problem I never think about beauty. I
only think about how to solve the problem. But when I have finished, if
the solution is not beautiful, I know it is wrong."
- Buckminster Fuller
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
More information about the Ocfs2-test-devel
mailing list