[Ocfs2-test-devel] [PATCH] ocfs2-test: add concurrent flock() test case, v3

tristan.ye tristan.ye at oracle.com
Sun Dec 14 21:33:37 PST 2008


Signed-off-by: Tristan Ye <tristan.ye at oracle.com>


On Mon, 2008-12-15 at 13:20 +0800, Coly Li wrote:
> This script is initialized by Sunil, to verify lockres mastery race in flock(). For further
> information of the lockres mastery race issue, read Novell bugzilla page:
> https://bugzilla.novell.com/show_bug.cgi?id=425491
> 
> Thanks to Sunil for initial script, thanks to Marcos and Tristan for productive comments.
> 
> Signed-off-by: Coly Li <coly.li at suse.de>
> ---
>  programs/flock_tests/Makefile                 |    2 +-
>  programs/flock_tests/concurrent_flock_test.pl |   58 +++++++++++++++++++++++++
>  2 files changed, 59 insertions(+), 1 deletions(-)
> 
> diff --git a/programs/flock_tests/Makefile b/programs/flock_tests/Makefile
> index 8b6bc5c..82659ec 100644
> --- a/programs/flock_tests/Makefile
> +++ b/programs/flock_tests/Makefile
> @@ -15,7 +15,7 @@ DIST_FILES = $(SOURCES)
> 
>  BIN_PROGRAMS = flock_unit_test
> 
> -BIN_EXTRA = run_flock_unit_test.py
> +BIN_EXTRA = run_flock_unit_test.py concurrent_flock_test.pl
> 
>  flock_unit_test: $(OBJECTS)
>  	$(LINK)
> diff --git a/programs/flock_tests/concurrent_flock_test.pl
> b/programs/flock_tests/concurrent_flock_test.pl
> new file mode 100644
> index 0000000..5fdf8d1
> --- /dev/null
> +++ b/programs/flock_tests/concurrent_flock_test.pl
> @@ -0,0 +1,58 @@
> +#!/usr/bin/perl
> +#
> +# concurrent_flock_test.pl - A handy tool to test concurrent flock() on single
> +#                            node
> +#
> +# Initialized by Sunil Mushran <sunil.mushran at oracle.com>
> +# Modified by Coly Li <coly.li at suse.de>
> +#
> +# Usage: concurrent_flock_test.pl <dir> <interation> <fork_number>
> +#
> +# Example: concurrent_flock_test.pl /mnt/test/ 5000 20
> +#
> +# /mnt/test is directory within mounted ocfs2 volume, the above example
> +# encloses the 20 fork loop into another loop that changes the filename.
> +# To startwith, touch 5000 files(test.flock%d). umount and mount again.
> +# This will drop the caches. Now before running any ls, run flock.pl.It
> +# will spawn 20 processes to flock() each file and wait till the 20 forks
> +# have exited before letting loose another 20 for the next file. (Makesure
> +# you have another node or two or more that have just mounted that volume.).
> +#
> +
> +
> +use warnings;
> +use Fcntl ':flock';
> +
> +my $dir=$ARGV[0];
> +my $interation=$ARGV[1];
> +my $fork_nr=$ARGV[2];
> +
> +$| = 1;
> +if (! ($dir && $interation && $fork_nr)) {
> +	print "Usage: concurrent_flock_test.pl <dir> <interation> <fork_number>\n";
> +	exit(1);
> +}
> +if (! -d $dir) {
> +	print "$dir is not directory.\n";
> +	exit(1);
> +}
> +
> +system("rm -f $dir/test.lock*");
> +for (my $y = 0; $y < $interation; $y ++) {
> +	my $file = $dir . "/test.lock" . $y;
> +
> +	printf "[%s] %s\n", $$, $file;
> +
> +	for (my $x = 0; $x < $fork_nr; $x ++) {
> +		my $pid = fork();
> +		if ($pid == 0) {
> +			my $fh;
> +			open($fh, ">> $file") or die("Can't open '$file': $!");
> +			printf "[%s] lock %s: %s\n", $$, $file,
> +			flock($fh, LOCK_EX) ? 'done' : $!;
> +			close($fh);
> +			exit(0);
> +		}
> +	}
> +	while (wait > 0) { ; }
> +}




More information about the Ocfs2-test-devel mailing list