[Ocfs2-test-devel] [PATCH 1/1] Ocfs2-test: Fix a bug in xattr-multi-test.c

Tristan Ye tristan.ye at oracle.com
Sun Dec 14 20:57:36 PST 2008


Should check the RC of function add_or_update_ea() somewhere to fail the test let
MPI execution abort.

Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
---
 programs/xattr_tests/xattr-multi-test.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/programs/xattr_tests/xattr-multi-test.c b/programs/xattr_tests/xattr-multi-test.c
index 4ecdfe4..ad6249d 100755
--- a/programs/xattr_tests/xattr-multi-test.c
+++ b/programs/xattr_tests/xattr-multi-test.c
@@ -516,7 +516,9 @@ static int one_round_run(enum FILE_TYPE ft, int round_no)
 			memset(xattr_value, 0, xattr_value_sz);
 			memset(xattr_value_get, 0, xattr_value_sz);
 			xattr_value_constructor(j);
-			add_or_update_ea(ft, fd, XATTR_REPLACE, "update");
+			ret = add_or_update_ea(ft, fd, XATTR_REPLACE, "update");
+			if (ret < 0 )
+				teardown(MPI_RET_FAILED);
 			if (ft == NORMAL)
 				ret = write(fd, write_buf, 100);
 		}
-- 
1.5.5




More information about the Ocfs2-test-devel mailing list