[Ocfs2-devel] [PATCH 0/1] test case for patch 1/1

[heming.zhao at suse.com]

On 6/25/22 20:47, Joseph Qi wrote:
> 
> 
> On 6/18/22 6:18 PM, heming.zhao at suse.com wrote:
>> On 6/18/22 10:35, Joseph Qi wrote:
>>>
>>>
>>> On 6/8/22 6:48 PM, Heming Zhao wrote:
>>>> === test cases ====
>>>>
>>>> <1> remount on local node for cluster env
>>>>
>>>> mount -t ocfs2 /dev/vdb /mnt
>>>> ... ...
>> how to calculate:
>> ```
>> my test disk is 500M raw file, attached to kvm-qemu with shared mode.
>> (my env) block size: 1K cluster size: 4K '//slot_map' inode number: 0xD.
>> debugfs: stat //slot_map
>>          Inode: 13   Mode: 0644   Generation: 4183895025 (0xf9612bf1)
>>          FS Generation: 4183895025 (0xf9612bf1)
>>          CRC32: 00000000   ECC: 0000
>>          Type: Regular   Attr: 0x0   Flags: Valid System
>>          Dynamic Features: (0x0)
>>          User: 0 (root)   Group: 0 (root)   Size: 4096
>>          Links: 1   Clusters: 1
>>          ctime: 0x62286e49 0x0 -- Wed Mar  9 17:07:21.0 2022
>>          atime: 0x62286e49 0x0 -- Wed Mar  9 17:07:21.0 2022
>>          mtime: 0x62286e4a 0x0 -- Wed Mar  9 17:07:22.0 2022
>>          dtime: 0x0 -- Thu Jan  1 08:00:00 1970
>>          Refcount Block: 0
>>          Last Extblk: 0   Orphan Slot: 0
>>          Sub Alloc Slot: Global   Sub Alloc Bit: 5
>>          Tree Depth: 0   Count: 51   Next Free Rec: 1
>>          ## Offset        Clusters       Block#          Flags
>>          0  0             1              74276           0x0
>>
>> 74276 * 1024 => 76058624 (0x4889000)
>> ```
>>
>> At last, do you think I could send v2 patch which includes part of ext4 mmp feature.
>> I plan to copy ext4_multi_mount_protect(), and won't include generating kmmpd kthread
>> code.
>> btw, to be honest, I can't totally got the idea of kmmpd. kmmpd does periodically
>> update/detect mmp area. And ext4_multi_mount_protect() already blocks new mounting
>> action. So in my view, kmmpd update/detect actions only work for user/something
>> directly modifies disk mmp area case. if my guess is right, the kmmpd is not necessary.
>>
> 
> Sorry for the late reply.
> Since now this feature is incomplete and o2cb is the default stack, I'd
> like take Junxiao's suggestion, we revert this feature first to quickly
> fix the regression.
> And we can take it again in the future once the feature is mature.
> 

Agree with your decision, I will file a new patch(es) for noclustered mount.

Thanks,
Heming