[Ocfs2-devel] [PATCH 24/26] xfs: fix pagecache truncation prior to reflink

[Christoph Hellwig]

On Mon, Oct 15, 2018 at 08:20:48PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong at oracle.com>
> 
> Prior to remapping blocks, it is necessary to remove pages from the
> destination file's page cache.  Unfortunately, the truncation is not
> aggressive enough -- if page size > block size, we'll end up zeroing
> subpage blocks instead of removing them.  So, round the start offset
> down and the end offset up to page boundaries.  We already wrote all
> the dirty data so the larger range shouldn't be a problem.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong at oracle.com>
> Reviewed-by: Dave Chinner <dchinner at redhat.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>