[Ocfs2-devel] [PATCH 04/15] xfs: update ctime and remove suid before cloning files

[Christoph Hellwig]

>  STATIC int
>  xfs_reflink_remap_prep(
> @@ -1302,6 +1303,30 @@ xfs_reflink_remap_prep(
>  	/* Zap any page cache for the destination file's range. */
>  	truncate_inode_pages_range(&inode_out->i_data, pos_out,
>  				   PAGE_ALIGN(pos_out + len) - 1);
> +
> +	/* If we're altering the file contents... */
> +	if (!is_dedupe) {

Nipick - even a clone might not alter the file content, we just have
no guarantee.  So maybe change the comment to:

	/* If we may alter the file contents.. */

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>