[Ocfs2-devel] [PATCH 1/2] ocfs2: fix panic due to unrecovered local alloc

[Junxiao Bi]

On 11/19/18 8:25 PM, Joseph Qi wrote:
>> diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
>> index 857bbbcd39f3..ea3493734ac6 100644
>> --- a/fs/ocfs2/localalloc.c
>> +++ b/fs/ocfs2/localalloc.c
>> @@ -345,13 +345,18 @@ int ocfs2_load_local_alloc(struct ocfs2_super *osb)
>>   	if (num_used
>>   	    || alloc->id1.bitmap1.i_used
>>   	    || alloc->id1.bitmap1.i_total
>> -	    || la->la_bm_off)
>> -		mlog(ML_ERROR, "Local alloc hasn't been recovered!\n"
>> +	    || la->la_bm_off) {
>> +		mlog(ML_ERROR, "inconsistent detected, clean journal with"
> Better to leave a blank space between "with" and "unrecovered" for readability.
> Other looks good.

Thanks. Will fix this.

Thanks,

Junxiao.

>
> With the above comments addressed,
> Acked-by: Joseph Qi<jiangqi903 at gmail.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20181120/109f4fbf/attachment.html