[Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c

Changwei Ge ge.changwei at h3c.com
Tue Dec 12 20:51:17 PST 2017


On 2017/12/13 12:03, Joseph Qi wrote:
> 
> 
> On 17/12/13 11:51, Changwei Ge wrote:
>> Stack variable fe is no longer used, so trim it to save some cpu cycles
>> and stack space.
>>

>> -	BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb,
>> ocfs2_blocks_to_clusters(bitmap_inode->i_sb, start_blk)));
> 
> Still malformed. You have to disable auto wrap length in your editor.

Hi Joseph,
Thanks for your tips, I will send a revised patch later.

Thanks,
Changwei

> 
> Thanks,
> Joseph
> 
>> +	BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb,
>> +				ocfs2_blocks_to_clusters(bitmap_inode->i_sb,
>> +							 start_blk)));





More information about the Ocfs2-devel mailing list