[Ocfs2-devel] [PATCH] ocfs2: clean dead code in suballoc.c

[Joseph Qi]

On 17/12/13 11:04, Changwei Ge wrote:
> Stack variable fe is no longer used, so trim it to save some cpu cycles
> and stack space.
> 
> Signed-off-by: Changwei Ge <ge.changwei at h3c.com>
> ---
>   fs/ocfs2/suballoc.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index 71f22c8fbffd..a74108d22d47 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -2566,7 +2566,6 @@ static int _ocfs2_free_clusters(handle_t *handle,
>   	int status;
>   	u16 bg_start_bit;
>   	u64 bg_blkno;
> -	struct ocfs2_dinode *fe;
> 
>   	/* You can't ever have a contiguous set of clusters
>   	 * bigger than a block group bitmap so we never have to worry
> @@ -2575,8 +2574,6 @@ static int _ocfs2_free_clusters(handle_t *handle,
>   	 * gotten tested really well. */
>   	BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, 
> ocfs2_blocks_to_clusters(bitmap_inode->i_sb, start_blk)));
> 
Here is malformed. Suggest explicitly split the long line into two as
well.

Thanks,
Joseph
> -	fe = (struct ocfs2_dinode *) bitmap_bh->b_data;
> -
>   	ocfs2_block_to_cluster_group(bitmap_inode, start_blk, &bg_blkno,
>   				     &bg_start_bit);
>