[Ocfs2-devel] [PATCH] ocfs2: fix a redundant re-initialization

[Gang He]

>>> 
> On 2016/5/23 10:30, Eric Ren wrote:
>> Obviously, memset() has zeroed the whole struct locking_max_version.
>> So, it's no need to zero its two fields individually.
>> 
>> Signed-off-by: Eric Ren <zren at suse.com>
> Looks good, thanks.
> Reviewed-by: Joseph Qi <joseph.qi at huawei.com>
Reviewed-by: Gang He <ghe at suse.com>

> 
>> ---
>>  fs/ocfs2/stackglue.c | 2 --
>>  1 file changed, 2 deletions(-)
>> 
>> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
>> index 5d965e8..855fb44 100644
>> --- a/fs/ocfs2/stackglue.c
>> +++ b/fs/ocfs2/stackglue.c
>> @@ -734,8 +734,6 @@ static void __exit ocfs2_stack_glue_exit(void)
>>  {
>>  	memset(&locking_max_version, 0,
>>  	       sizeof(struct ocfs2_protocol_version));
>> -	locking_max_version.pv_major = 0;
>> -	locking_max_version.pv_minor = 0;
>>  	ocfs2_sysfs_exit();
>>  	if (ocfs2_table_header)
>>  		unregister_sysctl_table(ocfs2_table_header);
>> 
> 
> 
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com 
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel