[Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec

piaojun piaojun at huawei.com
Fri Mar 25 21:25:55 PDT 2016


Clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec.

Signed-off-by: Jun Piao <piaojun at huawei.com>
---
 fs/ocfs2/alloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
index d002579..2b8b721 100644
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
@@ -5334,7 +5334,7 @@ static int ocfs2_truncate_rec(handle_t *handle,
 {
 	int ret;
 	u32 left_cpos, rec_range, trunc_range;
-	int wants_rotate = 0, is_rightmost_tree_rec = 0;
+	int is_rightmost_tree_rec = 0;
 	struct super_block *sb = ocfs2_metadata_cache_get_super(et->et_ci);
 	struct ocfs2_path *left_path = NULL;
 	struct ocfs2_extent_list *el = path_leaf_el(path);
@@ -5431,7 +5431,6 @@ static int ocfs2_truncate_rec(handle_t *handle,

 		memset(rec, 0, sizeof(*rec));
 		ocfs2_cleanup_merge(el, index);
-		wants_rotate = 1;

 		next_free = le16_to_cpu(el->l_next_free_rec);
 		if (is_rightmost_tree_rec && next_free > 1) {
-- 
1.8.4.3

On 2016/3/26 3:36, Andrew Morton wrote:
> On Thu, 17 Mar 2016 17:11:27 +0800 piaojun <piaojun at huawei.com> wrote:
> 
>> Clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec.
>>
>> Signed-off-by: Jun Piao <piaojun at huawei.com>
>> ---
>>  alloc.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/alloc.c b/alloc.c
>> index d002579..2b8b721 100644
>> --- a/alloc.c
>> +++ b/alloc.c
> 
> This should be
> 
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> 
> please.  `patch -p1' form.
> 
> 
> 
> .
> 
I make a new patch according to your suggestion, thks.




More information about the Ocfs2-devel mailing list