[Ocfs2-devel] [PATCH] ocfs2/dlm: fix a variable overflow problem in dlmdomain.c
piaojun
piaojun at huawei.com
Mon Mar 14 04:57:07 PDT 2016
In dlm_send_join_cancels(), unsigned int node is assigned -1, this will
lead variable overflow. Although this won't cause any runtime problem,
the code looks a little uncoordinated.
Signed-off-by: Jun Piao <piaojun at huawei.com>
Reviewed-by: Joseph Qi <joseph.qi at huawei.com>
---
dlm/dlmdomain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c
index 2ee7fe7..61bafa7 100644
--- a/dlm/dlmdomain.c
+++ b/dlm/dlmdomain.c
@@ -1395,8 +1395,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm,
unsigned long *node_map,
unsigned int map_size)
{
- int status, tmpstat;
- unsigned int node;
+ int status, tmpstat, int node;
if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) *
sizeof(unsigned long))) {
--
1.8.4.3
More information about the Ocfs2-devel
mailing list