[Ocfs2-devel] [PATCH 4/6] ocfs2: o2hb: add some user/debug log
Eric Ren
zren at suse.com
Sun Jan 24 22:00:32 PST 2016
Hi Juxiao,
On Mon, Jan 25, 2016 at 12:29:05PM +0800, Junxiao Bi wrote:
> On 01/25/2016 11:28 AM, Eric Ren wrote:
> >> @@ -449,7 +470,11 @@ static int o2hb_nego_timeout_handler(struct o2net_msg *msg, u32 len, void *data,
> >> > static int o2hb_nego_approve_handler(struct o2net_msg *msg, u32 len, void *data,
> >> > void **ret_data)
> >> > {
> >> > - o2hb_arm_timeout((struct o2hb_region *)data);
> >> > + struct o2hb_region *reg = (struct o2hb_region *)data;
> >> > +
> >> > + printk(KERN_NOTICE "o2hb: negotiate timeout approved by master node on region %s (%s).\n",
> >> > + config_item_name(®->hr_item), reg->hr_dev_name);
> >> > + o2hb_arm_timeout(reg);
> > Why mix the use of printk and mlog? Any rules to follow?
> printk is log for user while mlog is log for debug.
Gotcha, thanks!
Eric
>
> Thanks,
> Junxiao.
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
More information about the Ocfs2-devel
mailing list