[Ocfs2-devel] [PATCH 2/6] ocfs2: o2hb: add NEGO_TIMEOUT message
Eric Ren
zren at suse.com
Sun Jan 24 21:59:12 PST 2016
On Mon, Jan 25, 2016 at 12:28:08PM +0800, Junxiao Bi wrote:
> On 01/25/2016 11:18 AM, Eric Ren wrote:
> >>
> >> > @@ -2039,13 +2086,30 @@ static struct config_item *o2hb_heartbeat_group_make_item(struct config_group *g
> >> >
> >> > config_item_init_type_name(®->hr_item, name, &o2hb_region_type);
> >> >
> >> > + /* this is the same way to generate msg key as dlm, for local heartbeat,
> >> > + * name is also the same, so make initial crc value different to avoid
> >> > + * message key conflict.
> >> > + */
> >> > + reg->hr_key = crc32_le(reg->hr_region_num + O2NM_MAX_REGIONS,
> >> > + name, strlen(name));
> >> > + INIT_LIST_HEAD(®->hr_handler_list);
> > Looks no need to initilize ->hr_handler_list here?
> Why? It is list head.
Oh, sorry, it should.
Another trivial, the label name "free_handler" sounds little strange. How about just
"unregister" or "unregister_handler"?
Thanks,
Eric
>
> Thanks,
> Junxiao.
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
More information about the Ocfs2-devel
mailing list