[Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang

Tariq Saeed tariq.x.saeed at oracle.com
Fri Jan 8 14:44:29 PST 2016


On 01/07/2016 05:45 PM, Mark Fasheh wrote:
>> 2. ocfs2_reflink ->  ocfs2_init_security_and_acl -> ocfs2_iop_set_acl
> Could you elaborate for me on the problem you found there?
The problem here is dropping dir lock in posix_acl_create after getting
default_acl and acl. These two can be changed by another node by
the time we get around to using  them in ocfs2_init_security_and_acl.

The old code in uek3 is mindful of this. In that code, 
ocfs2_init_security_and_acl
gets the dir lock and keeps it until the acls of new node are set.
Thanks
-Tariq



More information about the Ocfs2-devel mailing list