[Ocfs2-devel] [PATCH] add OCFS2_LOCK_IGNORE_BLOCKED arg_flags to ocfs2_cluster_lock() to prevent hang

[Junxiao Bi]

Hi Mark,

We may fix this issue in another way, without recursive locking and
without refactoring. We can check before asking for the second locking,
if lock is already hold, then skip the second locking, do you agree
fixing like this?

Thanks,
Junxiao.
On 01/05/2016 08:35 AM, Mark Fasheh wrote:
> On Mon, Jan 04, 2016 at 12:57:37PM -0800, Tariq Saeed wrote:
>>
>> On 12/29/2015 04:34 PM, Mark Fasheh wrote:
>>> NACK - as I explained earlier on this list we need to refactor the code to
>> Not sure how things work in the open source world. Is refactoring to be 
>> picked by
>> somebody soon?
> 
> No problem, A couple explanations  / notes:
> 
> 1) CC me with your patches (someone had to point the last one out to me).
> 
> I'll get to reviewing most things but if you CC me then it can happen
> sooner.
> 
> 
> 2) You are fixing the bug and sending the patches. We usually expect the
> sender to incorporate feedback into their patch so the answer would be that
> you get to to the refactoring :)
> 
> If you need to make small changes to the VFS to let this happen (sometimes
> we might want 'nolock' variants of funtions, etc), do them in seperate
> patches and send them along with your changes.
> 
> Hope this helps,
> 	--Mark
> 
> --
> Mark Fasheh
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>