[Ocfs2-devel] [PATCH] ocfs2: clean up an unuseful goto in ocfs2_put_slot function

Joseph Qi joseph.qi at huawei.com
Sun Apr 10 20:48:41 PDT 2016


Hi Guozhonghua,
You should follow the rules when submitting patches. Please refer
Documentation\SubmittingPatches for details.

Thanks,
Joseph

On 2016/4/7 17:16, Guozhonghua wrote:
> The goto is not useful in the function ocfs2_put_slot, so delete it.
> 
> Signed-off-by: Guozhonghua <guozhonghua at h3c.com>
> 
> --- ocfs2.org/slot_map.c        2016-03-25 15:29:22.175343770 +0800
> +++ ocfs2/slot_map.c    2016-04-07 16:53:25.540793954 +0800
> @@ -535,12 +535,9 @@ void ocfs2_put_slot(struct ocfs2_super *
>         spin_unlock(&osb->osb_lock);
> 
>         status = ocfs2_update_disk_slot(osb, si, slot_num);
> -       if (status < 0) {
> +       if (status < 0)
>                 mlog_errno(status);
> -               goto bail;
> -       }
> -
> -bail:
> +
>         ocfs2_free_slot_info(osb);
>  }
> -------------------------------------------------------------------------------------------------------------------------------------
> 本邮件及其附件含有杭州华三通信技术有限公司的保密信息,仅限于发送给上面地址中列出
> 的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、
> 或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本
> 邮件!
> This e-mail and its attachments contain confidential information from H3C, which is
> intended only for the person or entity whose address is listed above. Any use of the
> information contained herein in any way (including, but not limited to, total or partial
> disclosure, reproduction, or dissemination) by persons other than the intended
> recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender
> by phone or email immediately and delete it!
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
> 




More information about the Ocfs2-devel mailing list