[Ocfs2-devel] ocfs2/dlm: Ignore LVBs of locks

Zhangguanghui zhang.guanghui at h3c.com
Fri May 15 20:39:42 PDT 2015


In the process of  dlm_prepare_lvb_for_migration,

if  all valid locks have not the  same LVB, then  BUGs.

the patch ensures that the other valid locks have the

same a LVB from the first valid lock  to solute the problem of BUGs


Finally, any feedback about this process (positive or negative) would be
greatly appreciated.
Thanks,
        --zgh


static void dlm_prepare_lvb_for_migration(struct dlm_lock *lock, struct dlm_migratable_lockres *mres,int queue)

--- dlmrecovery.c 2014-12-17 01:39:45.000000000 +0800
+++ dlmrecovery0.c 2015-05-16 10:59:59.683924862 +0800
@@ -1215,7 +1215,10 @@
lock->lockres->lockname.len, lock->lockres->lockname.name,
lock->ml.node);
dlm_print_one_lock_resource(lock->lockres);
- BUG();
+
+ /* Ensure the lvb copied for migration matches the first valid locks */
+ memcpy(lock->lksb->lvb, mres->lvb, DLM_LVB_LEN);
+ return;
}



On Mon, Jan 25, 2010 at 04:57:39PM -0800, Sunil Mushran wrote:
> During lock resource migration, o2dlm fills the packet with a LVB from the
> first valid lock. For sanity, it ensures that the other valid locks have the
> same LVB. If not, it BUGs.
>
> The valid locks are ones that have granted EX or PR lock levels and are either
> on the Granted or Converting lists. Locks in the Blocked list cannot have a
> valid LVB.




________________________________
zhangguanghui 10102
-------------------------------------------------------------------------------------------------------------------------------------
本邮件及其附件含有杭州华三通信技术有限公司的保密信息,仅限于发送给上面地址中列出
的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、
或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本
邮件!
This e-mail and its attachments contain confidential information from H3C, which is
intended only for the person or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not limited to, total or partial
disclosure, reproduction, or dissemination) by persons other than the intended
recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender
by phone or email immediately and delete it!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20150516/20f47b0d/attachment.html 


More information about the Ocfs2-devel mailing list