[Ocfs2-devel] [PATCH RESEND] ocfs2: use retval instead of status for checking error

Andrew Morton akpm at linux-foundation.org
Sat May 2 21:13:19 PDT 2015


On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn <daeseok.youn at gmail.com> wrote:

> 2015-04-24 10:45 GMT+09:00 Daeseok Youn <daeseok.youn at gmail.com>:
> > The use of 'status' in __ocfs2_add_entry() can return wrong
> > value. Some functions' return value in __ocfs2_add_entry(),
> > i.e ocfs2_journal_access_di() is saved to 'status'.
> > But 'status' is not used in 'bail' label for returning result
> > of __ocfs2_add_entry().
> >
> > So use retval instead of status.
> >
> > Reviewed-by: Joseph Qi <joseph.qi at huawei.com>
> > Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com>
> > ---
> Andrew.
> 
> How is it going this patch, please check for me.

I merged this over a week ago and it is in linux-next:
http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-use-retval-instead-of-status-for-checking-error.patch

You were sent a commit email at the time.



More information about the Ocfs2-devel mailing list