[Ocfs2-devel] [PATCH 1/3] ocfs2: remove unneeded variable 'status'

Andrew Morton akpm at linux-foundation.org
Thu Feb 26 13:33:29 PST 2015


On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn at gmail.com> wrote:

> Use 'retval' instead of 'status'.
> 

The patch does a lot more than this.  It causes __ocfs2_add_entry to
propagate error codes which were previously dropped on the floor.

Please update the changelog to fully explain the functional changes and
to explain why they are desirable.

After the patch there is still one unchecked call to
ocfs2_journal_access_di() and one unchecked call to
ocfs2_journal_access_db().  Probably these are bugs.




More information about the Ocfs2-devel mailing list