[Ocfs2-devel] [patch 05/28] ocfs2: acknowledge return value of ocfs2_error()

[Andrew Morton]

On Fri, 28 Aug 2015 16:20:43 -0700 Mark Fasheh <mfasheh at suse.de> wrote:

> On Wed, Aug 26, 2015 at 03:11:32PM -0700, Andrew Morton wrote:
> > From: Goldwyn Rodrigues <rgoldwyn at suse.de>
> > Subject: ocfs2: acknowledge return value of ocfs2_error()
> > 
> > Caveat: This may return -EROFS for a read case, which seems wrong.  This
> > is happening even without this patch series though.  Should we convert
> > EROFS to EIO?
> 
> I must be doing something wrong because in the kernels I've looked at,
> ocfs2_error() is a void function.

The preceding patch (ocfs2: add errors=continue) changed the
ocfs2_error() return type.