[Ocfs2-devel] [patch 12/28] ocfs2: optimize error handling in dlm_request_join

Mark Fasheh mfasheh at suse.de
Mon Aug 31 12:39:13 PDT 2015


On Wed, Aug 26, 2015 at 03:11:51PM -0700, Andrew Morton wrote:
> From: "Norton.Zhu" <norton.zhu at huawei.com>
> Subject: ocfs2: optimize error handling in dlm_request_join
> 
> Currently error handling in dlm_request_join is a little obscure, so
> optimize it to promote readability.
> 
> If packet.code is invalid, reset it to JOIN_DISALLOW to keep it meaningful. 
> It only influences the log printing.
> 
> Signed-off-by: Norton.Zhu <norton.zhu at huawei.com>
> Cc: Srinivas Eeda <srinivas.eeda at oracle.com>
> Cc: Mark Fasheh <mfasheh at suse.com>
> Cc: Joel Becker <jlbec at evilplan.org>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>

Great cleanup btw, turning that mess into a switch statement, thanks.

Reviewed-by: Mark Fasheh <mfasheh at suse.de>

--
Mark Fasheh



More information about the Ocfs2-devel mailing list