[Ocfs2-devel] [patch 11/28] ocfs2: extend enough credits for freeing one truncate record while replaying truncate records
Mark Fasheh
mfasheh at suse.de
Fri Aug 28 16:55:43 PDT 2015
On Wed, Aug 26, 2015 at 03:11:48PM -0700, Andrew Morton wrote:
> From: Xue jiufei <xuejiufei at huawei.com>
> Subject: ocfs2: extend enough credits for freeing one truncate record while replaying truncate records
>
> Now function ocfs2_replay_truncate_records() first modifies tl_used, then
> calls ocfs2_extend_trans() to extend transactions for gd and alloc inode
> used for freeing clusters. jbd2_journal_restart() may be called and it
> may happen that tl_used in truncate log is decreased but the clusters are
> not freed, which means these clusters are lost. So we should avoid
> extending transactions in these two operations.
>
> Signed-off-by: joyce.xue <xuejiufei at huawei.com>
> Cc: Mark Fasheh <mfasheh at suse.com>
> Cc: Joel Becker <jlbec at evilplan.org>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
> ---
>
> fs/ocfs2/alloc.c | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff -puN fs/ocfs2/alloc.c~extend-enough-credits-for-freeing-one-truncate-record-while-replaying-truncate-records fs/ocfs2/alloc.c
> --- a/fs/ocfs2/alloc.c~extend-enough-credits-for-freeing-one-truncate-record-while-replaying-truncate-records
> +++ a/fs/ocfs2/alloc.c
<looks good>
> @@ -6063,7 +6060,7 @@ int __ocfs2_flush_truncate_log(struct oc
> goto out_mutex;
> }
>
> - handle = ocfs2_start_trans(osb, OCFS2_TRUNCATE_LOG_UPDATE);
> + handle = ocfs2_start_trans(osb, OCFS2_TRUNCATE_LOG_FLUSH_ONE_REC);
> if (IS_ERR(handle)) {
> status = PTR_ERR(handle);
> mlog_errno(status);
Why is this particular change here?
--Mark
--
Mark Fasheh
More information about the Ocfs2-devel
mailing list