[Ocfs2-devel] [patch 01/28] ocfs2: set filesytem read-only when ocfs2_delete_entry failed.
Mark Fasheh
mfasheh at suse.de
Fri Aug 28 16:03:08 PDT 2015
On Wed, Aug 26, 2015 at 03:11:21PM -0700, Andrew Morton wrote:
> From: jiangyiwen <jiangyiwen at huawei.com>
> Subject: ocfs2: set filesytem read-only when ocfs2_delete_entry failed.
>
> In ocfs2_rename, it will lead to an inode with two entried(old and new) if
> ocfs2_delete_entry(old) failed. Thus, filesystem will be inconsistent.
>
> The case is described below:
>
> ocfs2_rename
> -> ocfs2_start_trans
> -> ocfs2_add_entry(new)
> -> ocfs2_delete_entry(old)
> -> __ocfs2_journal_access *failed* because of -ENOMEM
> -> ocfs2_commit_trans
>
> So filesystem should be set to read-only at the moment.
>
> Signed-off-by: Yiwen Jiang <jiangyiwen at huawei.com>
> Cc: Joseph Qi <joseph.qi at huawei.com>
> Cc: Joel Becker <jlbec at evilplan.org>
> Cc: Mark Fasheh <mfasheh at suse.com>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Reviewed-by: Mark Fasheh <mfasheh at suse.de>
--
Mark Fasheh
More information about the Ocfs2-devel
mailing list