[Ocfs2-devel] [PATCH 2/2] ocfs2_iop_set/get_acl() are also called from the VFS so we must take inode lock

Tariq Saeed tariq.x.saeed at oracle.com
Thu Apr 16 11:51:41 PDT 2015


On 04/16/2015 01:48 AM, Junxiao Bi wrote:
> I think "return ERR_PTR(ret);" is more simple here.
True. I am guilty of just copy-paste from an older kernel.
> Also why you check "status != -ENOENT" in ocfs2_iop_set_acl() but not here
Same reason -- copy-and-paste from an older kernel. Having said that,
I don't think it matters one way or the other. Does it?

I have no objection to applying your suggestions and re-submitting the
patch. Mark, what is the protocol for that. Do I need to mention that 
this is a re-sumit?
Thanks,
-Tariq Saeed



More information about the Ocfs2-devel mailing list