[Ocfs2-devel] Question about commit cf1b5ea1c5cd

Joseph Qi joseph.qi at huawei.com
Mon Apr 13 20:06:40 PDT 2015


Hi Viro,
I have questions about your commit cf1b5ea1c5cd
("[regression] ocfs2: do *not* increment ->ki_pos twice").
Yes, ->ki_pos is increased in generic_file_direct_write(). But
*ppos doesn't. So I increase it here for further use in
generic_perform_write.
After this, ->ki_pos and *ppos are equal. Then after buffer write, I
only get written_buffered increased into ->ki_pos, so ->ki_pos is *not*
increased twice.




More information about the Ocfs2-devel mailing list