[Ocfs2-devel] vfs: Add general support to enforce project quota limits

Jan Kara jack at suse.cz
Mon Apr 13 05:19:00 PDT 2015


On Mon 13-04-15 14:48:51, Dan Carpenter wrote:
> Ah.  Thanks for looking into it.  Smatch can't understand bit flags like
> that yet.  And it also still doesn't track pointers very well.
> Eventually those things will be improved.
> 
> I see now that this out of bounds is also prevented in
> vfs_load_quota_inode().  We don't allow "(type == PRJQUOTA &&
> sb->dq_op->get_projid == NULL)".  Since, ->get_projid() is always NULL
> for OCFS2 that means "type" can't equal to PRJQUOTA (2).
> 
> Hm..  is ->get_projid set anywhere?  Cscope and smatch can't find it if
> it is.
  Not yet. There are ext4 patches floating around that will use this.

								Honza
-- 
Jan Kara <jack at suse.cz>
SUSE Labs, CR



More information about the Ocfs2-devel mailing list