[Ocfs2-devel] [PATCH] ocfs2: improve code readability
Sudip Mukherjee
sudipm.mukherjee at gmail.com
Fri Oct 31 05:29:21 PDT 2014
code was getting confusing as the priority of both the
operators ! and & are same.
this change is done to just to improve the readability
of the code.
Signed-off-by: Sudip Mukherjee <sudip at vectorindia.org>
---
hi,
i hope this is the way Weiwei Wang has thought of the logic when giving that BUG_ON,
please discard this patch if this assumption was worng.
fs/ocfs2/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 62620ab..1a05574 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -2764,7 +2764,7 @@ int ocfs2_del_inode_from_orphan(struct ocfs2_super *osb,
goto bail_unlock_orphan;
}
- BUG_ON(!di->i_flags & cpu_to_le32(OCFS2_DIO_ORPHANED_FL));
+ BUG_ON(!(di->i_flags & cpu_to_le32(OCFS2_DIO_ORPHANED_FL)));
/* Only delete entry if OCFS2_ORPHANED_FL not set, or
* there are two entries added */
--
1.8.1.2
More information about the Ocfs2-devel
mailing list