[Ocfs2-devel] [PATCH 0/7 v5] ocfs2: support append O_DIRECT write

Joseph Qi joseph.qi at huawei.com
Tue Oct 28 05:59:58 PDT 2014


Currently in case of append O_DIRECT write (block not allocated yet),
ocfs2 will fall back to buffered I/O. This has some disadvantages.
Firstly, it is not the behavior as expected.
Secondly, it will consume huge page cache, e.g. in mass backup scenario.
Thirdly, modern filesystems such as ext4 support this feature.

In this patch set, the direct I/O write doesn't fallback to buffer I/O
write any more because the allocate blocks are enabled in direct I/O
now.

changelog:
v5 <- v4:
 -- take Andrew's advice of using do_div() instead of mod(%).
 -- using ocfs2_bytes_to_clusters instead of ocfs2_clusters_for_bytes,
    because we need the floor when calculate v_cpos, not roof.
 -- call __blockdev_direct_IO instead of blockdev_direct_IO in
    ocfs2_direct_IO_write to pass end_io function.
 -- do not override the return value of __blockdev_direct_IO.
 -- after calling generic_file_direct_write, *ppos is already changed,
    so do not change it again in ocfs2_file_write_iter.
 -- fix the issue when do append O_DIRECT write and unlink/rename
    concurrently.

Any feedback are always appreciated.
Thanks.




More information about the Ocfs2-devel mailing list