[Ocfs2-devel] [PATCH v5 7/7] fs: add a flag for per-operation O_DSYNC semantics
Jeff Moyer
jmoyer at redhat.com
Thu Nov 6 15:46:08 PST 2014
Milosz Tanski <milosz at adfin.com> writes:
> - if (type == READ && (flags & RWF_NONBLOCK))
> - return -EAGAIN;
> + if (type == READ) {
> + if (flags & RWF_NONBLOCK)
> + return -EAGAIN;
> + } else {
> + if (flags & RWF_DSYNC)
> + return -EINVAL;
> + }
Minor nit, but I'd rather read something that looks like this:
if (type == READ && (flags & RWF_NONBLOCK))
return -EAGAIN;
else if (type == WRITE && (flags & RWF_DSYNC))
return -EINVAL;
I won't lose sleep over it, though.
Reviewed-by: Jeff Moyer <jmoyer at redhat.com>
More information about the Ocfs2-devel
mailing list