[Ocfs2-devel] [PATCH] ocfs2: Remove some redundant casting

Jeff Liu jeff.liu at oracle.com
Tue May 13 19:51:14 PDT 2014


Tao's Oracle email address was obsolete.

On 05/10/2014 06:45 AM, George Spelvin wrote:
> There are two standard techniques for dereferencing structures pointed
> to by void *: cast to the right type each time they're used, or assign
> to local variables of the right type.
> 
> But there's no need to do *both*.
> 
> Signed-off-by: George Spelvin <linux at horizon.com>
> ---
> Obviously, this makes zero difference to the generated code, but
> it's prettier.

Indeed :), the patch looks good to me.

Reviewed-by: Jie Liu <jeff.liu at oracle.com>


Thanks,
-Jeff




More information about the Ocfs2-devel mailing list