[Ocfs2-devel] [patch 4/8] ocfs2: call ocfs2_update_inode_fsync_trans when updating any inode

Mark Fasheh mfasheh at suse.de
Sun Mar 30 19:05:46 PDT 2014


On Wed, Mar 19, 2014 at 02:10:02PM -0700, Andrew Morton wrote:
> From: "Darrick J. Wong" <darrick.wong at oracle.com>
> Subject: ocfs2: call ocfs2_update_inode_fsync_trans when updating any inode
> 
> Ensure that ocfs2_update_inode_fsync_trans() is called any time we touch
> an inode in a given transaction.  This is a follow-on to the previous
> patch to reduce lock contention and deadlocking during an fsync operation.

This looks fine but I have a question - what happens if a future patch adds
some disk structure change but forgets to call
ocfs2_update_inode_fsync_trans(). Could we wind up skipping some blocks to
sync in that case?
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list