[Ocfs2-devel] [patch 2/8] ocfs2: flock: drop cross-node lock when failed locally

Mark Fasheh mfasheh at suse.de
Sun Mar 30 18:30:47 PDT 2014


On Wed, Mar 19, 2014 at 02:10:00PM -0700, Andrew Morton wrote:
> From: Wengang Wang <wen.gang.wang at oracle.com>
> Subject: ocfs2: flock: drop cross-node lock when failed locally
> 
> ocfs2_do_flock() calls ocfs2_file_lock() to get the cross-node clock and
> then call flock_lock_file_wait() to compete with local processes.  In case
> flock_lock_file_wait() failed, say -ENOMEM, clean up work is not done. 
> This patch adds the cleanup --drop the cross-node lock which was just
> granted.

Out of curiousity was this a bug someone hit, or did you catch this
via code review.

Reviewed-by: Mark Fasheh <mfasheh at suse.de>
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list