[Ocfs2-devel] [PATCH 2/6] Add clustername while creating new lockspace

Mark Fasheh mfasheh at suse.de
Mon Sep 9 14:42:20 PDT 2013


On Thu, Sep 05, 2013 at 10:27:37PM -0500, Goldwyn Rodrigues wrote:
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 01b8516..60f3d8e 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2239,6 +2239,9 @@ static int ocfs2_initialize_super(struct super_block *sb,
>  			status = -EINVAL;
>  			goto bail;
>  		}
> +		memcpy(osb->osb_cluster_name,
> +			OCFS2_RAW_SB(di)->s_cluster_info.ci_cluster,
> +			OCFS2_CLUSTER_NAME_LEN);

In the case of no extended cluster info (think o2cb stack) this field would
be NULL. Have you tested with o2cb to see what happens?

Btwm, since o2cb wouldn't ever use that info you could always put a dummy
value there if need be.
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list