[Ocfs2-devel] [PATCH 0/5] nocontrold: Eliminating ocfs2_controld v3

[Goldwyn Rodrigues]

On 10/03/2013 06:25 AM, Lars Marowsky-Bree wrote:
> On 2013-10-03T00:48:55, Goldwyn Rodrigues <rgoldwyn at suse.de> wrote:
>
> Hi Goldwyn,
>
> just a minor comment:
>
>> For backward compatibility, we are keeping the controld handling code. Once
>> enough time has passed we can remove a significant portion of the code.
>
> Can we add this to Documentation/fs/ocfs2.txt, or maybe print a one-time
> message on activating the deprecated mode with an intended removal date?
> (I'd propose end-of-2014.)

We already print a message in dmesg saying:
printk(KERN_NOTICE "ocfs2: You seem to be using an older "
                    "version of dlm_controld and/or ocfs2-tools."
                    " Please consider upgrading.\n");

Adding a date to this should not be a problem.

>
> And, perhaps, a compile-time option to disable this earlier, so that
> users can choose the stacks they want to build the kernel with.
>

This would a be a couple of ifdef's in user_cluster_connect(). What do 
other ocfs2 developers feel about this?


-- 
Goldwyn