[Ocfs2-devel] [PATCH] ocfs2: drop the unwanted null byte in dentry lock name

Mark Fasheh mfasheh at suse.de
Thu Nov 28 08:40:44 PST 2013


On Wed, Nov 27, 2013 at 03:38:41PM -0800, Andrew Morton wrote:
> On Wed, 27 Nov 2013 17:05:00 +0800 Joseph Qi <joseph.qi at huawei.com> wrote:
> 
> > Dentry lock name is made up of the type 'N', the parent blkno and its
> > blkno represented as a binary value.
> > Now there is a null byte between parent blkno and the binary blkno
> > value, so drop it.
> 
> Geeze.
> 
> What are the runtime effects of this change?

This will change the over-the-wire protocol, so big NACK for this
patch please. Some of the lock names are binary and have been forever now.
We have a limited amount of space in the name and some lock types would have
names too long if we stringified every field.
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list