[Ocfs2-devel] [PATCH] ocfs2_prep_new_orphaned_file should return ret

[xiaowei.hu]

if there is error happen in , for example EIO in 
__ocfs2_prepare_orphan_dir, ocfs2_prep_new_orphaned_file will release 
the inode_ac, the the caller of ocfs2_prep_new_orphaned_file get a 0 
return, it will refer to a NULL ocfs2_alloc_context struct in the 
following functions.Kernel panic happens.

On 05/22/2013 10:31 AM, shencanquan wrote:
> if return 0,  what's wrong with this?
> On 2013/5/22 9:43, xiaowei.hu at oracle.com wrote:
>> From: "Xiaowei.Hu"<xiaowei.hu at oracle.com>
>>
>> ---
>>   fs/ocfs2/namei.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
>> index 50c93a8..422cbe0 100644
>> --- a/fs/ocfs2/namei.c
>> +++ b/fs/ocfs2/namei.c
>> @@ -2216,7 +2216,7 @@ out:
>>
>>       brelse(orphan_dir_bh);
>>
>> -    return 0;
>> +    return ret;
>>   }
>>
>>   int ocfs2_create_inode_in_orphan(struct inode *dir,
>
>